[GH-448] Fix multiple SocketConnections in Overworld #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lotuuu
requested review from
AminArria,
manucamejo,
tvillegas98,
martinacantaro,
mgrunwaldt,
ncontinanza,
saugon,
marco-paulucci,
agustinesco,
tkz00,
Nico-Sanchez,
AngieDutra and
alfopisano
as code owners
lotuuu
changed the title
ncontinanza
approved these changes
Jun 12, 2024
| { | ||
| Debug.Log("SocketConnection ConnectToSession"); |
There was a problem hiding this comment.
Suggested change
| Debug.Log("SocketConnection ConnectToSession"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #448
Motivation
A new SocketConnection was being instantiated every time we went into the Overworld scene, which started a new WS connection.
With this PR we singletonize the singleton (? to actually keep it as the unique instance.
We also need to fix the ServerSelect stuff a bit: if we called Init there, we would get an unexisting gameobject error. Instead, we use the currently existing singleton instance, connecting to the newly configured domain.
Summary of changes
How has this been tested?
Play around with the swapping of servers and entering and leaving the Overworld scene. When connecting to localhost, you should see one
[info] Websocket INIT calledlog in the server for each time you connected to the backend through the Server Selector, and not one for each time you entered the Overworld scene.Checklist